-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecating tf2 C Headers #4732
Deprecating tf2 C Headers #4732
Conversation
Signed-off-by: CursedRock17 <[email protected]>
@CursedRock17, your PR has failed to build. Please check CI outputs and resolve issues. |
@CursedRock17 some of these headers don’t appear to be renamed. CI does not build. We also run on Rolling binaries, so if it’s not been merged and released yet, then we would need to wait for that to happen before updating Nav2 |
I should mention this is meant to be a preemptive PR for if/when the related pull request gets approved. I'm also working on a backport so there won't be distribution issues |
With the recent backports merged, this PR should be good for review. |
@CursedRock17, your PR has failed to build. Please check CI outputs and resolve issues. |
@CursedRock17 this is still blocked by rolling not released into binaries with the update to geometry2. Once that is in (so that rolling binaries have it), we can merge. I'm looking at the rolling binaries and still seeing |
@CursedRock17 I reran CI now that the binaries are out. It looks like there's a linting issue. There also appears to be 2x tests that are now deterministically failing -- I'll plan to look at those this afternoon when I get a moment. Edit: I just fixed the linting issue Something very odd is going on with those tests that are failing. I'm printing out the values from
I'm printing out values and seeing the |
Signed-off-by: Steve Macenski <[email protected]>
@CursedRock17 thanks for the help in opening this PR, but I'll take it from here in #4823 since I needed to rebase and make some changes + fix the issues mentioned above. Thanks a ton! |
Basic Info
Description of contribution in a few bullet points
Related to this pull request in
geometry2
in which we deprecated the.h
style headers in favor of.hpp
.Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: