Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed with latest ros2 rolling source builds #4816

Closed
chanhhoang99 opened this issue Dec 24, 2024 · 6 comments
Closed

Build failed with latest ros2 rolling source builds #4816

chanhhoang99 opened this issue Dec 24, 2024 · 6 comments

Comments

@chanhhoang99
Copy link

Bug report

Required Info:

  • Operating System:
    • Ubuntu 24.04.1 LTS
  • ROS2 Version:
    • rolling ridley
  • Version or commit hash:
  • DDS implementation:
    • Fast-RTPS

Steps to reproduce issue

Build ros2 from source: https://docs.ros.org/en/rolling/Installation/Alternatives/Ubuntu-Development-Setup.html

Then follow instruction to build nav2 https://docs.nav2.org/development_guides/build_docs/index.html

Expected behavior

Build should be passed

Actual behavior

Received failure log:

In file included from /home/server/nav2_ws/src/navigation2/nav2_util/src/robot_utils.cpp:21:
/home/server/ros2_ws/install/tf2/include/tf2/tf2/convert.h:39:7: error: #warning CONVERT_HEADER_DEPERCATION [-Werror=cpp]
   39 |     # warning CONVERT_HEADER_DEPERCATION
      |       ^~~~~~~
In file included from /home/server/nav2_ws/src/navigation2/nav2_util/include/nav2_util/robot_utils.hpp:27,
                 from /home/server/nav2_ws/src/navigation2/nav2_util/src/robot_utils.cpp:22:
/home/server/ros2_ws/install/tf2/include/tf2/tf2/time.h:36:7: error: #warning TIME_HEADER_DEPERCATION [-Werror=cpp]
   36 |     # warning TIME_HEADER_DEPERCATION
      |       ^~~~~~~
In file included from /home/server/nav2_ws/src/navigation2/nav2_util/include/nav2_util/robot_utils.hpp:28:
/home/server/ros2_ws/install/tf2/include/tf2/tf2/transform_datatypes.h:39:7: error: #warning TRANSFORM_DATATYPES_HEADER_DEPERCATION [-Werror=cpp]
   39 |     # warning TRANSFORM_DATATYPES_HEADER_DEPERCATION
      |       ^~~~~~~
In file included from /home/server/nav2_ws/src/navigation2/nav2_util/src/costmap.cpp:18:
/home/server/ros2_ws/install/tf2/include/tf2/tf2/LinearMath/Quaternion.h:23:7: error: #warning QUATERNION_HEADER_DEPERCATION [-Werror=cpp]
   23 |     # warning QUATERNION_HEADER_DEPERCATION
      |       ^~~~~~~
cc1plus: all warnings being treated as errors

Additional information

There is change from upstream of ros2/tf2 headers, should we use -Wno-error=cpp to ignore this error ?

@SteveMacenski
Copy link
Member

SteveMacenski commented Jan 2, 2025

A few updates were made before the holidays in TF -- we have an open PR for updating to resolve the API change here #4732. I retriggered CI to check if we're all building again and will merge once ready!

Thanks for the report

@SteveMacenski SteveMacenski linked a pull request Jan 2, 2025 that will close this issue
7 tasks
@SteveMacenski SteveMacenski changed the title Build failed with latest ros2 rolling Build failed with latest ros2 rolling source builds Jan 2, 2025
@SteveMacenski
Copy link
Member

@chanhhoang99 are you building geometry2 rolling from source? I'm not seeing it in the binaries yet and there hasn't been a rolling release since the depreciation warnings were added.

@chanhhoang99
Copy link
Author

Hi @SteveMacenski ,
Yes, I built geometry2 from source.

@SteveMacenski
Copy link
Member

@chanhhoang99 we should have this resolved sometime this month for source builds, for now you could use the tagged version of rolling's geometry_msgs instead of the latest on the main branch (0.40.0). That would fix your source build version (unless you critically needed something that has been added in the last ~6-8 weeks).

We could also update Nav2's CI to have geometry2 built from source as well and merge this in, but that would break main for all other users on rolling's binaries. I'd wager there are more binary-rolling users than source-rolling users, so I want to make sure I'm considerate of other developer's needs.

@SteveMacenski
Copy link
Member

L.O.L. for me

The rolling release just happened 20 hours ago. I kick started that PR job and likely should be able to merge this within an hour to resolve the problem 😆

@SteveMacenski
Copy link
Member

Merged! Thanks for the report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants