Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecating C API for TF2 and fixing test failures #4823

Merged
merged 4 commits into from
Jan 4, 2025

Conversation

SteveMacenski
Copy link
Member

@SteveMacenski SteveMacenski commented Jan 4, 2025

Supersedes #4732

There's an issue still yet where an erroneous collision is being detected in the rotation shim controller, but the other errors are handled. It was fixed temporarily by moving the origin of the costmap to -2.5, -2.5 for a 5x5m window, but caused other tests that rely on that default to fail. I need to investigate why this is failing now and if only moving the origin is the right choice.

Fully resolved :-)

Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Copy link

codecov bot commented Jan 4, 2025

@SteveMacenski SteveMacenski merged commit 4e5d2df into main Jan 4, 2025
11 checks passed
@SteveMacenski SteveMacenski deleted the depreciate_c_headers2 branch January 4, 2025 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant