4766 different surface counts

[ggartside]

Pull request overview

• Fixes Different number of wall surfaces between ThreeJS reverse translator and Floorspace reverse translator #4766

To resolve an issue caused by removing inline vertices that altered the direction vector of the combined edges enough to make surface matching fail

This call was originally added to resolve the issue with Space 2 - 1 in the floorplan_school model where the vertices are not ordered correctly and the resulting surfaces are overlapping. Removing this call meant that the way wall sub-surfaces are made and associated with the walls had to be modified to allow for the situation that we are no longer able to match edge ids

This fix has also resulted in creating issue #4776 and #4783

Pull Request Author

• Model API Changes / Additions
• Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
• Model API methods are tested (in src/model/test)
• EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
• If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
• If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
• Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
• All new and existing tests passes
• If methods have been deprecated, update rest of code to use the new methods

Labels:

• If change to an IDD file, add the label IDDChange
• If breaking existing API, add the label APIChange
• If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• Code Style, strip trailing whitespace, etc.
• All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
• Labeling is ok
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified

[jmarrec]

at 5e06a4 you have failing tests. There are also conflicts.

The following tests FAILED:

2524 - ModelFixture.FloorspaceReverseTranslator_Issue_4312 (Failed)
2526 - ModelFixture.FloorspaceReverseTranslator_Issue_4488 (Failed)
2530 - ModelFixture.FloorspaceReverseTranslator_Issue_4237 (Failed)

Errors while running CTest

[jmarrec]

@ggartside I've merged develop and resolved conflicts, and cleaned up a bunch of things. There are still some remaining comments that are left open.

[jmarrec]

Thanks for the changes @ggartside . I have fixed up the cppcheck and merged latest develop in. There are only 2 open comments that needs addressing at this point.

[ggartside]

Added a new commit that applies a scale factor when converting between openstudio and boost data formats to improve the numerical accuracy of the boolean operations.

Idea came from this comment in the boostorg/geometry repo boostorg/geometry#1034 (comment) where the author indicates that scaling the values by 10 improved the result and talks about rounding to an integer grid, so by increasing the range of values we pass to boost we should be improving the resolution of the integer rounding

[ci-commercialbuildings]

CI Results for cc46ff5:

• Ubuntu 18.04:

  • OpenStudio-3.5.2-alpha+cc46ff57df-Ubuntu-18.04.deb
  • OpenStudio-3.5.2-alpha+cc46ff57df-Ubuntu-18.04.tar.gz

• Ubuntu 20.04:

  • OpenStudio-3.5.2-alpha+cc46ff57df-Ubuntu-20.04.deb
  • OpenStudio-3.5.2-alpha+cc46ff57df-Ubuntu-20.04.tar.gz
  • perf_test/results.html

• Darwin:

  • OpenStudio-3.5.2-alpha+cc46ff57df-Darwin-x86_64.dmg
  • OpenStudio-3.5.2-alpha+cc46ff57df-Darwin-x86_64.tar.gz

• Windows:

• Code Coverage:

[jmarrec]

Ubuntu test failures are unrelated:

The following tests FAILED:
	639 - BCLFixture.RemoteBCLTest (Failed)
	640 - BCLFixture.RemoteBCLTest2 (Failed)
	642 - BCLFixture.RemoteBCLMetaSearchTest (Failed)
	643 - BCLFixture.RemoteBCL_EncodingURI (Failed)