Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-correct ground adjacency/boundary for floor js json import #4204

Closed
antonszilasi opened this issue Feb 11, 2021 · 1 comment · Fixed by #4777
Closed

In-correct ground adjacency/boundary for floor js json import #4204

antonszilasi opened this issue Feb 11, 2021 · 1 comment · Fixed by #4777

Comments

@antonszilasi
Copy link

antonszilasi commented Feb 11, 2021

Occasionally I am seeing floors which are not on the ground floor with ground contact adjacencies.

An example can be seen here:

image

Given that it is on the 2nd story this floor should have a surface adjacency

Find the floor js json here: https://drive.google.com/file/d/1zP3kdnXn1PYlAzkBwdnibYutRyTgsxII/view?usp=sharing

and resulting osm here: https://drive.google.com/file/d/1zP3kdnXn1PYlAzkBwdnibYutRyTgsxII/view?usp=sharing

Environment

OpenStudio-3.0.1

@antonszilasi antonszilasi added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Feb 11, 2021
@tijcolem tijcolem added component - Geometry Translator and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Feb 19, 2021
@tijcolem tijcolem assigned tijcolem and unassigned lgentile Nov 5, 2021
@ggartside
Copy link
Collaborator

@antonszilasi Hi I'm looking at this issue to see if it has been resolved and I'm having an issue getting the test file from your google drive. If you still have it can you email it to me at gerard.gartside at d-alchemy.com. I will also request permission to get it from your google drive. Thanks

@ggartside ggartside linked a pull request Feb 7, 2023 that will close this issue
19 tasks
@tijcolem tijcolem assigned ggartside and unassigned tijcolem Feb 7, 2023
@tijcolem tijcolem added this to the OpenStudio SDK 3.6.0 milestone Feb 10, 2023
@ggartside ggartside removed a link to a pull request Feb 15, 2023
19 tasks
@ggartside ggartside linked a pull request Feb 15, 2023 that will close this issue
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants