Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4766 different surface counts #4777

Merged
merged 28 commits into from
Mar 6, 2023
Merged

4766 different surface counts #4777

Show file tree
Hide file tree
Changes from 27 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
6c351c8
Fixes 4766: Different number of wall surfaces between ThreeJS reverse…
ggartside Dec 20, 2022
7a1de5f
After removing the call to fix 4766 had to fix how wall surfaces are …
ggartside Dec 21, 2022
703d5b2
And here come the clang changes
ggartside Dec 21, 2022
c511950
Fixes 4776: Missing sunbsurfaces and surface nbot subdivided
ggartside Jan 4, 2023
65d7d15
<< operator for Point3dVectorVector
ggartside Jan 17, 2023
420a01b
New and updated tests and test files of course
ggartside Jan 17, 2023
86022b0
Resolves 4783 in subtract() (and other changes)
ggartside Jan 17, 2023
59da5fe
clang-format does its stuff
ggartside Jan 17, 2023
594182f
Issue with cmake file
ggartside Jan 17, 2023
5ea06a4
cpp-check
ggartside Jan 18, 2023
c144d14
Merge branch 'develop' into 4766-Different-surface-counts
jmarrec Feb 15, 2023
633d51c
Minor changes
jmarrec Feb 15, 2023
db79456
More minor changes
jmarrec Feb 15, 2023
8538114
Add missing 4237 + Fix wrong path in test
jmarrec Feb 15, 2023
2cca961
Modernize entire code in Intersection.cpp + suppress constStatement m…
jmarrec Feb 15, 2023
186be15
Merge remote-tracking branch 'origin/develop' into 4766-Different-sur…
jmarrec Feb 15, 2023
6d76a4f
Vector initializer & operator << for list of point3d vectort
ggartside Feb 15, 2023
fed66ef
Corrected triangle count for test for 4738
ggartside Feb 15, 2023
c8d2e21
cppcheck and clang changes
ggartside Feb 15, 2023
f6e7e42
fixup cppcheck
jmarrec Feb 16, 2023
33c424f
Merge branch 'develop' into 4766-Different-surface-counts
jmarrec Feb 16, 2023
3358487
Merge branch 'develop' into 4766-Different-surface-counts
jmarrec Feb 16, 2023
5e62c35
Resolving final issues related to PR 4777
ggartside Feb 16, 2023
39df28a
Merge branch '4766-Different-surface-counts' of https://github.com/NR…
ggartside Feb 16, 2023
247b2bf
Changing meter limit to fix the area after intersection errrors cause…
ggartside Feb 20, 2023
65f0544
Applies a scale factor to the polygon data as it is converted between…
ggartside Mar 1, 2023
b270448
Merged deveop on to branch
ggartside Mar 1, 2023
cc46ff5
Update src/utilities/geometry/Intersection.cpp
ggartside Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/cppcheck.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
--suppress=constParameterCallback:src/utilities/idd/benchmark/LoadIdd_Benchmark.cpp \
--suppress=constParameterCallback:src/utilities/idf/benchmark/IdfObjectParse_Benchmark.cpp \
--suppress=constParameterCallback:src/utilities/idf/benchmark/LoadIdfFile_Benchmark.cpp \
--suppress=constStatement:src/utilities/geometry/Intersection.cpp \
--inline-suppr \
--inconclusive \
--template='[{file}:{line}]:({severity}),[{id}],{message}' \
Expand Down
8 changes: 8 additions & 0 deletions resources/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,15 @@ set(utilities_resources_src
utilities/Geometry/surface_match_floorplan.json
utilities/Geometry/threejs.json
utilities/Geometry/window_floorplan.json
utilities/Geometry/issue-4203.json
utilities/Geometry/issue-4222.json
utilities/Geometry/issue-4237.json
utilities/Geometry/issue-4312.json
utilities/Geometry/issue-4313.json
utilities/Geometry/issue-4323.json
utilities/Geometry/issue-4488.json
utilities/Geometry/issue-4670.json
utilities/Geometry/floorplan_mcve.json
utilities/Geometry/shadingtest.json
utilities/Geometry/minimal_GLTF_File.gltf
utilities/Geometry/7-7_Windows_Complete.gltf
Expand Down
Loading