Code

4766 different surface counts#4777

Code

Merged

jmarrec merged 28 commits intodevelopNREL/OpenStudio:developfrom 4766-Different-surface-countsNREL/OpenStudio:4766-Different-surface-countsCopy head branch name to clipboardMar 6, 2023

+36,283-242

Commits

Commits on Dec 20, 2022

• Fixes 4766: Different number of wall surfaces between ThreeJS reverse translator and Floorspace reverse translator

  ggartside

  committed
  6c351c8

Commits on Dec 21, 2022

• After removing the call to fix 4766 had to fix how wall surfaces are created

  ggartside

  committed
  7a1de5f

• And here come the clang changes

  ggartside

  committed
  703d5b2

Commits on Jan 4, 2023

• Fixes 4776: Missing sunbsurfaces and surface nbot subdivided

  ggartside

  committed
  c511950

Commits on Jan 17, 2023

• << operator for Point3dVectorVector

  ggartside

  committed
  65d7d15

• New and updated tests and test files of course

  ggartside

  committed
  420a01b

• Resolves 4783 in subtract() (and other changes)

  ggartside

  committed
  86022b0

• clang-format does its stuff

  ggartside

  committed
  59da5fe

• Issue with cmake file

  ggartside

  committed
  594182f

Commits on Jan 18, 2023

• cpp-check

  ggartside

  committed
  5ea06a4

Commits on Feb 15, 2023

• Merge branch 'develop' into 4766-Different-surface-counts

  jmarrec

  committed
  c144d14

• Minor changes

  jmarrec

  committed
  633d51c

• More minor changes

  jmarrec

  committed
  db79456

• Add missing 4237 + Fix wrong path in test

  jmarrec

  committed
  8538114

• Modernize entire code in Intersection.cpp + suppress constStatement misfire at file level for cppcheck

  jmarrec

  committed
  2cca961

• Merge remote-tracking branch 'origin/develop' into 4766-Different-surface-counts

  jmarrec

  committed
  186be15

• Vector initializer & operator << for list of point3d vectort

  ggartside

  committed
  6d76a4f

• Corrected triangle count for test for 4738

  ggartside

  committed
  fed66ef

• cppcheck and clang changes

  ggartside

  committed
  c8d2e21

Commits on Feb 16, 2023

• fixup cppcheck

  jmarrec

  committed
  f6e7e42

• Merge branch 'develop' into 4766-Different-surface-counts

  jmarrec

  committed
  33c424f

• Merge branch 'develop' into 4766-Different-surface-counts

  jmarrec

  authored
  3358487

• Resolving final issues related to PR 4777

  ggartside

  committed
  5e62c35

• Merge branch '4766-Different-surface-counts' of https://github.com/NREL/OpenStudio into 4766-Different-surface-counts

  ggartside

  committed
  39df28a

Commits on Feb 20, 2023

• Changing meter limit to fix the area after intersection errrors caused by the shringk/inflate to remove spikes. Usually an issue at vertices with a very small internal angle (pointy)

  ggartside

  committed
  247b2bf

Commits on Mar 1, 2023

• Applies a scale factor to the polygon data as it is converted between boost and openstudio formats all boost valculations are effectively performed in mm and not m as the scale factor is 1000

  ggartside

  committed
  65f0544

• Merged deveop on to branch

  ggartside

  committed
  b270448

Commits on Mar 3, 2023

• Update src/utilities/geometry/Intersection.cpp

  Show description for cc46ff5
  

  ggartside

  and

  jmarrec

  committed
  cc46ff5