Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing wall sub-surfaces and wall surface not subdivided correctly #4776

Closed
ggartside opened this issue Dec 21, 2022 · 0 comments · Fixed by #4777
Closed

Missing wall sub-surfaces and wall surface not subdivided correctly #4776

ggartside opened this issue Dec 21, 2022 · 0 comments · Fixed by #4777

Comments

@ggartside
Copy link
Collaborator

Issue overview

This is an issue in both the ThreeJS reverse translator and the Floorspace reverse translator so that suggests the issue lies in code that is common to both import paths.

Current Behavior

One external wall is missing a window subsurface and is not subdivided as it should be as part of the wall surface is internal and part is external

ThreeJS....
image

Floorspace
image

Expected Behavior

The wall should be subdivided and contain a window sub surface like this...
image

As can be seen in the original floorspace model
image

Steps to Reproduce

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Platform (Operating system, version):
  • Version of OpenStudio (if using an intermediate build, include SHA):

Context

@ggartside ggartside added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Dec 21, 2022
@ggartside ggartside changed the title Missing wall sub-surfaces and wall surface not subdivided correcfly Missing wall sub-surfaces and wall surface not subdivided correctly Dec 21, 2022
@tijcolem tijcolem added component - Geometry Translator severity - Minor Bug and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Jan 13, 2023
@ggartside ggartside linked a pull request Feb 15, 2023 that will close this issue
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants