refactor: rename views.ts to file-routes.ts #2271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also renames views.json to file-routes.json
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2271 +/- ##
=======================================
Coverage 93.77% 93.77%
=======================================
Files 65 65
Lines 1639 1639
Branches 368 368
=======================================
Hits 1537 1537
Misses 67 67
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
taefi
added a commit
to vaadin/flow
that referenced
this pull request
Mar 27, 2024
Follow up for vaadin/hilla#2271 NOTE: the vaadin/hilla#2271 also keeps the generation of views.ts temporarily to prevent possible snapshot build failures. After these two PRs (on both sides) merged successfully, the generation of views.ts would be removed from Hilla codebase.
|
Lodin
approved these changes
Apr 3, 2024
taefi
added a commit
that referenced
this pull request
Apr 12, 2024
This is a follow-up PR for #2271
Lodin
pushed a commit
that referenced
this pull request
Apr 16, 2024
This is a follow-up PR for #2271 Co-authored-by: Luciano Vernaschi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This renames the
views.tstofile-routes.ts(and also renamesviews.jsontofile-routes.jsonfor the sake of uniformity), but temporarily keeps theviews.tsas well for the transition period and compatibility to prevent snapshot build failures.Later, when RouterBuilder is merged and Flow adopted the change, the redundant generation of
views.tsshould be removed completely.Fixes #2239
Fixes #2281