refactor: import file-routes.js instead of views.js in Flow.tsx #19059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up for vaadin/hilla#2271 NOTE: the vaadin/hilla#2271 also keeps the generation of views.ts temporarily to prevent possible snapshot build failures. After these two PRs (on both sides) merged successfully, the generation of views.ts would be removed from Hilla codebase.
|
mshabarov
reviewed
Mar 28, 2024
| @@ -223,7 +223,7 @@ private String getFlowTsxFileContent(boolean frontendRoutesTsExists) | |||
| return content.replace("//%toReactRouterImport%", | |||
| "import { toReactRouter } from '@vaadin/hilla-file-router/runtime.js';") | |||
| .replace("//%viewsJsImport%", | |||
| "import views from 'Frontend/generated/views.js';") | |||
| "import views from 'Frontend/generated/file-routes.js';") | |||
There was a problem hiding this comment.
This wouldn't be needed after we switch to RouterBuilder API, because views.js won't be used by Flow anymore.
There was a problem hiding this comment.
OK, so we can close this PR for good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for vaadin/hilla#2271
NOTE: the vaadin/hilla#2271 also keeps the generation of views.ts temporarily to prevent possible snapshot build failures.
Please feel free to add any changes needed for a smooth transition, if needed.
After these two PRs (on both sides) merged successfully, the generation of views.ts would be removed from Hilla codebase.