Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PiT 24.4: Regression in alpha19 projects with client routes fail in windows #19093

Closed
Tracked by #5012
manolo opened this issue Apr 3, 2024 · 4 comments
Closed
Tracked by #5012

Comments

@manolo
Copy link
Member

manolo commented Apr 3, 2024

Description of the bug

java.nio.file.InvalidPathException: Illegal char <:> at index 2: /D:/a/platform/platform/tmp/react-tutorial/src/main/frontend/generated/views.json
	at java.base/sun.nio.fs.WindowsPathParser.normalize(WindowsPathParser.java:182) ~[na:na]
	at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:153) ~[na:na]
	at java.base/sun.nio.fs.WindowsPathParser.parse(WindowsPathParser.java:77) ~[na:na]
	at java.base/sun.nio.fs.WindowsPath.parse(WindowsPath.java:92) ~[na:na]
	at java.base/sun.nio.fs.WindowsFileSystem.getPath(WindowsFileSystem.java:232) ~[na:na]
	at java.base/java.nio.file.Path.of(Path.java:147) ~[na:na]
	at java.base/java.nio.file.Paths.get(Paths.java:69) ~[na:na]
	at com.vaadin.hilla.route.ClientRouteRegistry.registerClientRoutes(ClientRouteRegistry.java:137) ~[hilla-endpoint-24.4.0.alpha18.jar:na]

Expected behavior

no failures

Minimal reproducible example

Run attached project in a Windows desktop

react-tutorial.zip

mvn install -Pproduction
java -jar -Dvaadin.productionMode target/*.jar

Versions

  • Vaadin / Flow version: 24.4.0.alpha19
  • OS version: Windows
@caalador
Copy link
Contributor

caalador commented Apr 4, 2024

This seems to be from the hilla ClientRouteRegistry that doesn't handle some paths correctly: com.vaadin.hilla.route.ClientRouteRegistry.registerClientRoutes(ClientRouteRegistry.java:137)

@tltv
Copy link
Member

tltv commented Apr 4, 2024

vaadin/hilla#2271 has a fix for this issue.

@mshabarov
Copy link
Contributor

Can we close this issue as it has a fix already merged?

@ZheSun88
Copy link
Contributor

ZheSun88 commented Apr 4, 2024

can be closed now, as it is fixed in alpha20

@ZheSun88 ZheSun88 closed this as completed Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants