Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not generate views.ts anymore #2320

Merged
merged 5 commits into from
Apr 16, 2024
Merged

chore: do not generate views.ts anymore #2320

merged 5 commits into from
Apr 16, 2024

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Apr 12, 2024

This is a follow-up for #2271

@taefi taefi requested review from Lodin and cromoteca April 12, 2024 13:25
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.44%. Comparing base (e0ee6ed) to head (2223186).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2320      +/-   ##
==========================================
- Coverage   95.44%   95.44%   -0.01%     
==========================================
  Files          67       67              
  Lines        4438     4431       -7     
  Branches      633      632       -1     
==========================================
- Hits         4236     4229       -7     
  Misses        162      162              
  Partials       40       40              
Flag Coverage Δ
unittests 95.44% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Lodin Lodin merged commit f84504e into main Apr 16, 2024
15 checks passed
@Lodin Lodin deleted the taefi/remove-views-ts branch April 16, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants