fix(lyrics-plus/netease): use PyNCMd API #2508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan93412
force-pushed
the
pan93412/netease-fix
branch
from
cc1c46b
to
01644b6
Compare
pan93412
changed the title
pan93412
changed the title
pan93412
force-pushed
the
pan93412/netease-fix
branch
from
01644b6
to
b1ffe37
Compare
pan93412
changed the title
pan93412
force-pushed
the
pan93412/netease-fix
branch
2 times, most recently
from
db261d9
to
8e345ce
Compare
The old xianqiao.wang API seems like removed; therefore, I switch it to PyNCMd, which is actively maintained.
pan93412
force-pushed
the
pan93412/netease-fix
branch
from
8e345ce
to
7ae16d2
Compare
rxri
requested changes
Aug 12, 2023
Besides, in Spotify Taiwan, the album name is in Traditional Chinese, which is not aligned with what NCM chooses. Therefore, I have written a simple converter that converts the Traditional Chinese album name to Simplified Chinese so that we can compare the correct album name in such cases.
pan93412
force-pushed
the
pan93412/netease-fix
branch
from
7ae16d2
to
e231bd6
Compare
rxri
approved these changes
Aug 12, 2023
kyrie25
approved these changes
Aug 12, 2023
|
I'm sorry to mention pull that's already finished, but I think it would be better to apply that patch to popupLyrics as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old xianqiao.wang API seems like removed; therefore, I switch it to PyNCMd, which is actively maintained.
Besides, in Spotify Taiwan, the album name is in Traditional Chinese, which is not aligned with what NCM chooses. Therefore, I have written a simple converter that converts the Traditional Chinese album name to Simplified Chinese so that we can compare the correct album name in such cases.
Note that: