Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lyrics-plus/netease): use PyNCMd API #2508

Merged
merged 2 commits into from
Aug 12, 2023
Merged

fix(lyrics-plus/netease): use PyNCMd API #2508

merged 2 commits into from
Aug 12, 2023

Commits on Aug 12, 2023

  1. refactor(lyrics-plus/netease): use PyNCMd API 

    The old xianqiao.wang API seems like removed;
therefore, I switch it to PyNCMd, which is
actively maintained.
    @pan93412
    pan93412 committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    9ae997f View commit details
    Browse the repository at this point in the history

  2. feat(lyrics-plus/netease): normalize album name before comparing 

    Besides, in Spotify Taiwan, the album name is in Traditional
Chinese, which is not aligned with what NCM chooses. Therefore,
I have written a simple converter that converts the Traditional
Chinese album name to Simplified Chinese so that we can compare
the correct album name in such cases.
    @pan93412
    pan93412 committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    e231bd6 View commit details
    Browse the repository at this point in the history