Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lyrics-plus/utils): force usage of OpenCC standard #2517

Merged
merged 2 commits into from
Aug 29, 2023

Conversation

Deskehs
Copy link
Contributor

@Deskehs Deskehs commented Aug 15, 2023

A small nit-pick about #2508, Traditional Chinese is divided to Hong Kong Traditional Chinese and Taiwan Traditional Chinese. Those regional variants of Traditional Chinese uses different characters in some instances, for example: 着 in Hong Kong and 著 in Taiwan.

When I first implement the function of converting Simplified Chinese to Traditional Chinese and vice versa. It became obvious that some songs uses either Hong Kong Traditional Chinese or Taiwan Traditional Chinese. Figuring out how to differentiate those two Traditional Chinese was hard until I dig into the OpenCC's character convert website. They pretend that those two as OpenCC Traditional Chinese standard (which is specific to OpenCC only) instead of figuring out what is what.

Seeing the commit, I see that in the implementation of converting song names from Traditional Chinese to Simplified Chinese, all Traditional Characters are treated as Taiwan Traditional Chinese, which might cause problems when converting characters specific to Hong Kong Traditional Chinese. This PR fixes that to what the OpenCC website (and my implementation of converting Traditional Chinese lyrics to Simplified Chinese) handles them.

The intention is to ensure accuracy and consistency in handling these different variations of Traditional Chinese.

@rxri rxri changed the title fix(lyrics-plus/utils): Forcing to use the OpenCC standard instead of Taiwan Traditional Chinese fix(lyrics-plus/utils): force usage of OpenCC standard Aug 16, 2023
@afonsojramos afonsojramos merged commit 55a7a30 into spicetify:master Aug 29, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants