Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lyrics-plus/netease): normalize album name before comparing #2509

Closed

Conversation

pan93412
Copy link
Contributor

@pan93412 pan93412 commented Aug 11, 2023

Based on: #2508 (fix(lyrics-plus/netease): use PyNCMd API)

@pan93412 pan93412 force-pushed the pan93412/ncm-normalize-album-name branch from 7200245 to f5f4fdb Compare August 11, 2023 15:50
@pan93412 pan93412 changed the title lyrics-plus/ncm: Normalize album name feat(lyrics-plus/netease): Normalize album name Aug 11, 2023
@pan93412 pan93412 force-pushed the pan93412/ncm-normalize-album-name branch from f5f4fdb to 834d118 Compare August 11, 2023 15:54
The old xianqiao.wang API seems like removed;
therefore, I switch it to PyNCMd, which is
actively maintained.
@pan93412 pan93412 force-pushed the pan93412/ncm-normalize-album-name branch from 834d118 to 2ec3abc Compare August 11, 2023 16:00
@pan93412 pan93412 changed the title feat(lyrics-plus/netease): Normalize album name feat(lyrics-plus/netease): normalize album name before comparing Aug 11, 2023
Copy link
Member

@kyrie25 kyrie25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the same diff as #2508 + more, submit only one PR with the relevant content or merge them together.

@pan93412
Copy link
Contributor Author

This has the same diff as #2508 + more, summit only one PR with the relevant content or merge them together.

Thanks! I have merged this PR to #2508, and I'll close the PR here :D

@pan93412 pan93412 closed this Aug 12, 2023
@pan93412 pan93412 deleted the pan93412/ncm-normalize-album-name branch August 12, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants