Code documentations and new event for confirm remove the image #1414
Conversation
… delete unused dependencies and upgrade all packages and plugins and remove gallery_saver which has not been updated for more than 23 months, it was a great plugin but it old now, and I also add some simple documentation and other minor improvements
…new event to allow the user to confirm removing the image before actually remove it, translated some text in Arabic languague since it was incorrect or missing
|
You have conflict |
Done |
|
All the tests have passed:
So why it all checks fail in GitHub?? if is this because of the conflict please rerun the tests with the latest commit. |
|
info • The line length exceeds the 80-character limit • flutter_quill_extensions/lib/flutter_quill_extensions.dart:85:81 • lines_longer_than_80_chars |
I forgot to run Now I have fixed the merge conflicts as well the test |
| ImageEmbedBuilder({required this.afterRemoveImageFromEditor}); | ||
| ImageEmbedBuilder({ | ||
| required this.afterRemoveImageFromEditor, | ||
| required this.shouldRemoveImageFromEditor, |
There was a problem hiding this comment.
This should probably be nullable, instead of passing the default parameter of the function that just returns true.
| @@ -15,13 +15,13 @@ dependencies: | |||
| flutter_colorpicker: ^1.0.3 | |||
| flutter_keyboard_visibility: ^5.4.1 | |||
| quiver: ^3.2.1 | |||
| url_launcher: ^6.1.12 | |||
| url_launcher: ^6.1.14 | |||
There was a problem hiding this comment.
Please don't bump minimum plugin versions unless there is a major version/breaking change or we need to use a api feature that's only in a newer plugin
Related to #1413 and
#1412
Made new changes