Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pruning unused translations and adding relevant ones #1424

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

LuchoTurtle
Copy link
Contributor

I was initially going to work on finishing #1403 (comment) but since #1414 has already been merged, I realised that some translations were needed and other weren't used. So I've refactored it!

In addition, I've added a warning in the README file regarding https://github.com/natsuk4ze/gal, as some permissions need to be added to some files (as noted in #1403 (comment)).

This should be a quick merge 👌

@singerdmx singerdmx merged commit 8a8b56d into singerdmx:master Oct 16, 2023
1 check passed
@LuchoTurtle LuchoTurtle deleted the translations_pruning branch October 16, 2023 19:31
@EchoEllet
Copy link
Collaborator

Thanks

@EchoEllet
Copy link
Collaborator

@singerdmx I made the message clearer to know if we are saving the image using network or from local storage (cached) just for testing purposes, do we need to have separate translations, one for network saved image and another for storage?

@LuchoTurtle
Copy link
Contributor Author

Yeah, I was a bit hesitant about having specific translations for each scenario, as it doesn't seem really useful to the end user.
But I kept it because I didn't want to meddle too much with the pre-existing code.

@EchoEllet
Copy link
Collaborator

Yeah, I was a bit hesitant about having specific translations for each scenario, as it doesn't seem really useful to the end user. But I kept it because I didn't want to meddle too much with the pre-existing code.

I thought the team would probably change the pull request code but I kept it like this so they could test it directly in the UI

so I remind them to change it if they want to

but it might be helpful to the end user to know if this image is from the cloud, by image URL, or locally in the sandboxed directory of the app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants