flutter_quill_extensions: replace gallery_saver with gal #1403
Conversation
|
@Jon-Salmon could you please publish a new version of package? |
There was a problem hiding this comment.
@santiagos01 There are some review items that need to be addressed before this can be released
| // Save image to a temporary path | ||
| final fileName = uri.pathSegments.isEmpty ? 'image.jpg' | ||
| : uri.pathSegments.last; | ||
| final imagePath = '${Directory.systemTemp.path}/menu-opt-$fileName'; |
There was a problem hiding this comment.
This should use a cache directory from path_provider. This method here may not work on android:
flutter/flutter#12116
NativeScript/android#828
There was a problem hiding this comment.
Oops, sorry, didn't notice that this doesn't work on android.
Has this been resolved?
There was a problem hiding this comment.
I think #1414 already fixed these.
| await imageFile.writeAsBytes(response.bodyBytes); | ||
|
|
||
| // Save image to gallery | ||
| await Gal.putImage(imagePath); |
There was a problem hiding this comment.
Should probably delete the temporary image after saving
There was a problem hiding this comment.
Ah right.., has this been resolved?
| image_picker: ">=0.8.5 <2.0.0" | ||
| photo_view: ^0.14.0 | ||
| video_player: ^2.7.0 | ||
| youtube_player_flutter: ^8.1.1 | ||
| gallery_saver: ^2.3.2 | ||
| gal: ^2.1.1 |
There was a problem hiding this comment.
The gal package requires some setup steps that the user has to take on install. These should be linked to from the readme
|
@Jon-Salmon , given the feedback you've provided, are you working on a PR to tackle these issues? If not, I could try and give it a whirl and open it myself. It would really be awesome if we could get a new package version going with these changes. The |
|
@LuchoTurtle Please feel free to as I don't have time to work on this currently. I was hoping @santiagos01 would update this but I've not heard anything yet |
|
Hi all, sorry just saw this again -- Can I check whether the issues mentioned above have been resolved? |
|
I believe the issues have already been fixed through #1414, @santiagos01 |
Resolves #1377