Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_quill_extensions] outdated dependency gallery_saver #1377

Closed
santiagos01 opened this issue Aug 26, 2023 · 3 comments · Fixed by #1403
Closed

[flutter_quill_extensions] outdated dependency gallery_saver #1377

santiagos01 opened this issue Aug 26, 2023 · 3 comments · Fixed by #1403

Comments

@santiagos01
Copy link
Contributor

flutter_quill_extensions currently depends on gallery_saver: ^2.3.2.

But the package is no longer maintained, and it's now causing issue due to outdated http version (CarnegieTechnologies/gallery_saver#205).

Proposal
Update to use it's replacement: https://pub.dev/packages/gal

@santiagos01 santiagos01 changed the title [flutter_quill_extensions] update outdated dependency gallery_saver [flutter_quill_extensions] outdated dependency gallery_saver Aug 26, 2023
@singerdmx
Copy link
Owner

Looks good. Could you please submit a PR?

@hectorAguero
Copy link

hectorAguero commented Sep 1, 2023

The difference betweengallery saver and other packages like gal or image_gallery_saver is that if the image is a url, those packages will not download the image, that's because they doesn't depend on http nor dio

So a PR should switch from gallery_saver to the choice package + the implementation to download an image, would be good if doesn't use any package, but using http is fine too.

@santiagos01
Copy link
Contributor Author

Sflr, have been occupied with other things. Just created #1403 to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants