-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New features and improvements #1419
New features and improvements #1419
Conversation
… delete unused dependencies and upgrade all packages and plugins and remove gallery_saver which has not been updated for more than 23 months, it was a great plugin but it old now, and I also add some simple documentation and other minor improvements
…new event to allow the user to confirm removing the image before actually remove it, translated some text in Arabic languague since it was incorrect or missing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jon-Salmon please have a look
@Jon-Salmon ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I'm happy with what you're trying to add, but a lot of this code is quite mangled up from what looks like being based off an old branch. I've tried to highlight where these issues are, but you are probably best rebasing off the current main.
Also, please update the changelog file
I have fixed almost all the issues, as I mentioned in the previous pull request my sleep is not regular Thank you for your time and efforts. |
@Jon-Salmon ping |
Looks pretty good! One final change from my perspective and then LGTM |
@freshtechtips please make the final change and let's merge it |
@freshtechtips can you resolve the conflict and I will merge it |
The conflict is from change log and version |
I fixed the conflicts and pushed the changes however it still shows me the message "This branch has conflicts that must be resolved" Do I need to do this in GitHub?? and then fetch the changes to merge them with my local one?? I want my local repository to be up to date because I plan on sending more pull requests for further improvements, that is if you want to or don't mind |
I did it from remote one on github since I will rebase anyway |
@Jon-Salmon you can make additional changes per your preference |
Features:
QuillImageUtilities
class which has helpful functions for developers, you could remove this if you want toImprovements:
And I don't know where there is a conflict between all the branches and some changes I already made before
for that conflict, I haven't slept in a while so I'm not focused, I could make more mistakes
And speaking of mistakes, the library should be tested on Windows and Linux as well
I have noticed some other bugs in the editor on macOS that are not related to the changes I made
Also on the web, there is a small issue I will leave it for someone else for now, but if no one migrates the code then I will have to do it myself
Web issue
and if you use
flutter_inappwebview
please update it to the minimum version since there was a bug that caused the app to not compile and install the pods in ios using CocoaPods, it has been fixed in the latest versionEdit: I think I have made the task for you guys more difficult since I didn't fetch the changes made by you and the others and then try to make the new changes, I fixed the conflicts however It requires more review from you
The branch is outdated
My previous pull request