Fix tests failure after rolling sync #5771
Merged
+73
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
mini-1235
commented
Dec 8, 2025
Comment on lines
-2
to
-4
| // All rights reserved. | ||
| // | ||
| // Software License Agreement (BSD License 2.0) |
Member
There was a problem hiding this comment.
These are pretty key points though that can't be removed. These have legal meaning
Collaborator
Author
There was a problem hiding this comment.
I am not familiar with the license things, but I saw the ros2 team removed it as well https://github.com/ros2/rcpputils/pull/37/files, should I keep it?
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Signed-off-by: mini-1235 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Decwest
pushed a commit
to Decwest/navigation2
that referenced
this pull request
Dec 10, 2025
* Fix tests and copyright Signed-off-by: mini-1235 <[email protected]> * Add delay so that transform can always be found Signed-off-by: mini-1235 <[email protected]> * Fix Signed-off-by: mini-1235 <[email protected]> * Retrigger CI Signed-off-by: mini-1235 <[email protected]> * Use event handler to avoid race condition Signed-off-by: mini-1235 <[email protected]> * Lint Signed-off-by: mini-1235 <[email protected]> * Retrigger CI Signed-off-by: mini-1235 <[email protected]> --------- Signed-off-by: mini-1235 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #5769, I will rebase after that is merged, since we need to get the base image updated.