-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Bugfix inactive publishers #5748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bugfix inactive publishers #5748
Conversation
Signed-off-by: Christopher Thompson <[email protected]>
Signed-off-by: Christopher Thompson <[email protected]>
Signed-off-by: Christopher Thompson <[email protected]>
|
Updated against main branch instead of jazzy |
|
|
||
| void Costmap2DPublisher::publishCostmap() | ||
| { | ||
| if(!active_) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if(!active_) { | |
| if (!active_) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is active_ ever set to true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good question. I naively thought it was already used and working. Will look into this.
|
@pele1410 any update? |
Basic Info
Description of contribution in a few bullet points
Prevent the costmap_2d_publisher from trying to publish when it is not active.
Description of documentation updates required from your changes
N/A
Description of how this change was tested
Replicated the steps to produce the issue in #5710 and did not see the issue.
Future work that may be required in bullet points
This is not likely the root cause for the out-of-bounds index access but:
For Maintainers:
backport-*.