Restructuring of the repository for better overview. #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
destogl
added
documentation
25 tasks
github-actions
bot
requested review from
bijoua29,
bmagyar,
mhubii,
peterdavidfagan and
Serafadam
|
@destogl Do we need the camera links/meshes on the rrbot? or should we also clean this up ans simplify the URDF files? |
|
@christophfroehlich everything is merged. Let's clean this up a bit and then we merge it into master.
No we don't need this. Would be great to remove it. |
Merged
This was
linked to
issues
Mar 3, 2023
* Create a demo that uses transmissions (#226) * add copy for transmission demo and set in the urdf * Renamed to rrbot_transmissions * Changed reduction value of transmission2 * Added the rrbot_transmissions_system_position_only Exact copy of rrbot_system_position_only for now. Using it from the transmission demo * Moved logger into its own variable * Uncrustify * Renamed hw interface to joint. Added actuator interfaces * Formatting. Remove comments * Using transmissions for joint and actuator interfaces Added a helper object to manage the joint to transmissions to actuator data handling * Propagating data between all the interfaces * Cleanup. Added some consts * Simulate motor motion * Added logging to periodically show interface data * Refactored the parameters a bit. Removed unused ones * Added try/catches where needed Checking joint consistency in the description not required. Already done by the parser * Added transmission demo to README * Use clang-format instead * rename transmissions ros2_control macro * Remove unnecessary actuator parameters * Typo * Removed gazebo, mock hardware and fake sensors from the transmission demo * Missing 'explicit' from constructor * Further cleanup of gazebo, mock hardware and fake sensors from the transmission demo * branding fix * Remove pointer definitions Co-authored-by: Bence Magyar <[email protected]> * Fixed comment about reserve Co-authored-by: Bence Magyar <[email protected]> * Renamed member variable and added description --------- Co-authored-by: Noel Jimenez <[email protected]> Co-authored-by: Bence Magyar <[email protected]> (cherry picked from commit 1007b1d) * Fix preformatted block * fix header guard --------- Co-authored-by: Jordan Palacios <[email protected]> Co-authored-by: Bence Magyar <[email protected]>
* First compilable version * Fix wrong paths * Fix rst * Update copyright Co-authored-by: Dr. Denis <[email protected]> * Restructure cmakelists * Add maintainer * Cleanup old paths * Update Dr. Denis' Email and add him as author. * Update maintainer * Use test_nodes from ros2_controllers * Fix trailing whitespaces * Fix rviz display * Add image to readme --------- Co-authored-by: Dr. Denis <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
Co-authored-by: Dr. Denis <[email protected]>
destogl
force-pushed
the
new-structure-of-master
branch
2 times, most recently
from
5d2bd1c
to
3ae05a4
Compare
destogl
force-pushed
the
new-structure-of-master
branch
from
3ae05a4
to
dddf1a2
Compare
…es for rolling semi-binary build.
destogl
force-pushed
the
new-structure-of-master
branch
from
dddf1a2
to
6b354fd
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the restructured version of the repository.
Each example should be submitted as separate PR to this branch.
All examples should be merged at once.
Resolves #231.
Before merging this PR we should at least do the following:
use_fake_hardwaretouse_mock_hardwarerrbot_base.launch.pyfrom example folders, i.e., rename it to example launch file and setup parameters needed for the example..rstfiles are integrated into documentation on control.ros.orgMake sure the example implements add details as: (copy this list the PR) - replaces #119