Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test nodes to ros2_controllers repository. #150

Closed
wants to merge 2 commits into from

Conversation

destogl
Copy link
Member

@destogl destogl commented Feb 9, 2022

Moving the test nodes to ros2_controllers repository so they can be easily relased.
Also the test nodes are actually testing controllers so the pacakge is also renamed to "ros2_controllers_test_nodes".


@codecov-commenter
Copy link

Codecov Report

Merging #150 (46e981c) into master (1db6634) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #150      +/-   ##
=========================================
  Coverage    0.00%   0.00%              
=========================================
  Files         234       6     -228     
  Lines       19071     489   -18582     
=========================================
+ Misses      19071     489   -18582     
Flag Coverage Δ
unittests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../ros2_control_demo_hardware/src/diffbot_system.cpp
...rol_demo_hardware/src/rrbot_system_with_sensor.cpp
.../ros2_control_demo_hardware/src/rrbot_actuator.cpp
...rol_demo_hardware/src/rrbot_system_with_sensor.cpp
.../ros2_control_demo_hardware/src/rrbot_actuator.cpp
...rol_demo_hardware/src/rrbot_system_with_sensor.cpp
...ardware/src/external_rrbot_force_torque_sensor.cpp
.../ros2_control_demo_hardware/src/diffbot_system.cpp
...l_demo_hardware/src/rrbot_system_position_only.cpp
...ardware/src/external_rrbot_force_torque_sensor.cpp
... and 230 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1db6634...46e981c. Read the comment docs.

@christophfroehlich
Copy link
Contributor

christophfroehlich commented Mar 28, 2023

This was already done by #232 in master, I changed this to targeting galactic branch

@destogl
Copy link
Member Author

destogl commented Mar 28, 2023

let's just close this. We don't need to care about galactic anymore at all. So I'll close this.

@destogl destogl closed this Mar 28, 2023
@destogl destogl deleted the move-test-nodes-to-controllers-repo branch March 28, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants