-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move toolchain wrappers to repo f4pga #2509
Conversation
a059250
to
10c7001
Compare
6c4b49a
to
8f54208
Compare
dddec93
to
c7384ac
Compare
81fb8b4
to
a056968
Compare
6906291
to
5525adc
Compare
e37a0b3
to
e895b07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
current version emits complete toolchain (including wrappers) when a user calls make install
. The new version will not do that at all - it will only emit architecture definitions. We should clearly say about this change somewhere (as it will be confusing for "old" users)
FTR, there is https://github.com/antmicro/f4pga-arch-defs/commits/umarcor/pip-req (note antmicro@c612abd) but unfortunately I couldn't get it to work...
|
sure, but this is CI only. I'm talking about users who would want to manually install stuff on their machines
|
c62cb0f
to
71d28ce
Compare
This PR was updated to install the f4pga package through the |
Signed-off-by: Unai Martinez-Corral <[email protected]>
Signed-off-by: Unai Martinez-Corral <[email protected]>
Signed-off-by: Unai Martinez-Corral <[email protected]>
71d28ce
to
d15d573
Compare
Signed-off-by: Unai Martinez-Corral <[email protected]>
d15d573
to
7e19522
Compare
LGTM. Merging. |
So what happened to these wrappers? Are they now stored in another repo, or are they gone completely? What's the upgrade path for users? |
@Xiretza the toolchain wrappers have been moved to the f4pga repository, but this is just a transition stage before switching to their newer Python version that are also in the f4pga repo. You can read about the CLI in the documentation. The current changes should be transparent to arch-defs users, but we will be heading towards adopting the new CLI in f4pga-examples so it effectlively becomes the default interface. |
Ah, I see, thanks for the information - I'll get acquainted with the new tooling then! |
So, we are in a transition period. Well, actually, we've spent the last 2-3 month transitioning (from Kokoro to GitHub runners, from SymbiFlow to F4PGA and now from makefiles to Python). If you want to bump the arch-defs packages in your environment, and keep using the same makefiles/scripts you have, I suggest to read #2669. You just need to define F4PGA_ENV_BIN and F4PGA_ENV_SHARE pointing to the Conda bin and the location where you extracted the packages, respectively. That will "temporarily stabilize" your setup, until you get familiar with the new tooling system (and we improve the docs about how to use |
No description provided.