Skip to content

fix: eliminate some unnecessary any casts#448

Merged
wschurman merged 1 commit intomainfrom
wschurman/02-15-fix_eliminate_some_unnecessary_any_casts
Feb 17, 2026
Merged

fix: eliminate some unnecessary any casts#448
wschurman merged 1 commit intomainfrom
wschurman/02-15-fix_eliminate_some_unnecessary_any_casts

Conversation

@wschurman
Copy link
Member

@wschurman wschurman commented Feb 16, 2026

Why

Did a brief audit of any casts in the library and removed ones that are no longer needed or could be replaced with a better concrete type.

How

Grep for as any, fix.

Test Plan

yarn tsc

Copy link
Member Author

wschurman commented Feb 16, 2026

@wschurman wschurman mentioned this pull request Feb 16, 2026
@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (517d57b) to head (1f19b78).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #448    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          109       109            
  Lines        16006     16000     -6     
  Branches      1419       861   -558     
==========================================
- Hits         16006     16000     -6     
Flag Coverage Δ
integration 23.34% <6.66%> (-0.01%) ⬇️
unittest 95.13% <93.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman changed the base branch from wschurman/02-14-fix_update_integration_test_to_use_blahentity.knexloader_syntax to graphite-base/448 February 16, 2026 21:23
@wschurman wschurman force-pushed the wschurman/02-15-fix_eliminate_some_unnecessary_any_casts branch from db42d00 to a83c7cd Compare February 16, 2026 23:38
@wschurman wschurman changed the base branch from graphite-base/448 to wschurman/02-16-fix_change_adaptor_-_adapter_for_consistency February 16, 2026 23:38
@wschurman wschurman force-pushed the wschurman/02-15-fix_eliminate_some_unnecessary_any_casts branch from a83c7cd to d5ce982 Compare February 17, 2026 16:38
@wschurman wschurman force-pushed the wschurman/02-16-fix_change_adaptor_-_adapter_for_consistency branch from 674d84f to 2175ffe Compare February 17, 2026 16:38
@wschurman wschurman requested review from ide and quinlanj February 17, 2026 17:08
@wschurman wschurman marked this pull request as ready for review February 17, 2026 17:08
@wschurman wschurman force-pushed the wschurman/02-15-fix_eliminate_some_unnecessary_any_casts branch from d5ce982 to 7397d82 Compare February 17, 2026 22:31
@wschurman wschurman force-pushed the wschurman/02-16-fix_change_adaptor_-_adapter_for_consistency branch from 2175ffe to 5efa7c1 Compare February 17, 2026 22:31
@wschurman wschurman force-pushed the wschurman/02-15-fix_eliminate_some_unnecessary_any_casts branch from 7397d82 to d4c6c1c Compare February 17, 2026 22:35
@wschurman wschurman force-pushed the wschurman/02-16-fix_change_adaptor_-_adapter_for_consistency branch from 5efa7c1 to 084bd11 Compare February 17, 2026 22:35
Copy link
Member Author

wschurman commented Feb 17, 2026

Merge activity

  • Feb 17, 10:40 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 17, 10:49 PM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 17, 10:52 PM UTC: @wschurman merged this pull request with Graphite.

@wschurman wschurman changed the base branch from wschurman/02-16-fix_change_adaptor_-_adapter_for_consistency to graphite-base/448 February 17, 2026 22:45
@wschurman wschurman changed the base branch from graphite-base/448 to main February 17, 2026 22:48
@wschurman wschurman force-pushed the wschurman/02-15-fix_eliminate_some_unnecessary_any_casts branch from d4c6c1c to 1f19b78 Compare February 17, 2026 22:49
@wschurman wschurman merged commit cc78029 into main Feb 17, 2026
5 checks passed
@wschurman wschurman deleted the wschurman/02-15-fix_eliminate_some_unnecessary_any_casts branch February 17, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants