Skip to content

fix: Add default for TSelectedFields for application-instantiated types#438

Merged
wschurman merged 1 commit intomainfrom
wschurman/02-13-fix_add_default_for_tselectedfields_for_application-instantiated_types
Feb 16, 2026
Merged

fix: Add default for TSelectedFields for application-instantiated types#438
wschurman merged 1 commit intomainfrom
wschurman/02-13-fix_add_default_for_tselectedfields_for_application-instantiated_types

Conversation

@wschurman
Copy link
Member

@wschurman wschurman commented Feb 13, 2026

Why

When testing an upgrade to this package in the Expo server application, noticed that this was a minor annoyance since TSelectedFields has a default in all other public API methods.

How

Add default to be consistent.

Test Plan

yarn tsc

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f5c728b) to head (8f11d91).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #438   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          109       109           
  Lines        16142     16142           
  Branches      1419      1434   +15     
=========================================
  Hits         16142     16142           
Flag Coverage Δ
integration 27.28% <100.00%> (ø)
unittest 95.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman mentioned this pull request Feb 15, 2026
@wschurman wschurman force-pushed the wschurman/02-13-fix_add_default_for_tselectedfields_for_application-instantiated_types branch from 0938147 to 2a319a4 Compare February 16, 2026 00:06
@wschurman wschurman force-pushed the wschurman/02-12-fix_pass_in_augmentable_classes_to_installation branch from ae2770a to 34057b8 Compare February 16, 2026 00:06
Copy link
Member Author

wschurman commented Feb 16, 2026

Merge activity

  • Feb 16, 8:58 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 16, 9:07 PM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 16, 9:10 PM UTC: @wschurman merged this pull request with Graphite.

@wschurman wschurman changed the base branch from wschurman/02-12-fix_pass_in_augmentable_classes_to_installation to graphite-base/438 February 16, 2026 21:03
@wschurman wschurman changed the base branch from graphite-base/438 to main February 16, 2026 21:06
@wschurman wschurman force-pushed the wschurman/02-13-fix_add_default_for_tselectedfields_for_application-instantiated_types branch from 2a319a4 to 8f11d91 Compare February 16, 2026 21:07
@wschurman wschurman merged commit 3d4aa0e into main Feb 16, 2026
5 checks passed
@wschurman wschurman deleted the wschurman/02-13-fix_add_default_for_tselectedfields_for_application-instantiated_types branch February 16, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants