Skip to content

fix: update integration test to use BlahEntity.knexLoader syntax#444

Merged
wschurman merged 3 commits intomainfrom
wschurman/02-14-fix_update_integration_test_to_use_blahentity.knexloader_syntax
Feb 16, 2026
Merged

fix: update integration test to use BlahEntity.knexLoader syntax#444
wschurman merged 3 commits intomainfrom
wschurman/02-14-fix_update_integration_test_to_use_blahentity.knexloader_syntax

Conversation

@wschurman
Copy link
Member

@wschurman wschurman commented Feb 14, 2026

Why

Part 4 of #441. This reverts the test changes to use the better pattern, though both work equivalently and are both tested.

How

Update tests.

Test Plan

Run tests

@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@ed6b2e0). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #444   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?       109           
  Lines           ?     15944           
  Branches        ?      1430           
========================================
  Hits            ?     15944           
  Misses          ?         0           
  Partials        ?         0           
Flag Coverage Δ
integration 23.44% <ø> (?)
unittest 95.09% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman mentioned this pull request Feb 15, 2026
@wschurman wschurman force-pushed the wschurman/02-14-fix_update_integration_test_to_use_blahentity.knexloader_syntax branch from 8d6818c to 8b010df Compare February 16, 2026 00:06
@wschurman wschurman force-pushed the wschurman/02-13-fix_revert_change_to_codemod_now_that_entity.knexloader_is_supported_again_via_subclass branch from c2f1892 to 40502d6 Compare February 16, 2026 00:06
Copy link
Member Author

wschurman commented Feb 16, 2026

Merge activity

  • Feb 16, 8:58 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 16, 9:23 PM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 16, 9:26 PM UTC: @wschurman merged this pull request with Graphite.

@wschurman wschurman changed the base branch from wschurman/02-13-fix_revert_change_to_codemod_now_that_entity.knexloader_is_supported_again_via_subclass to graphite-base/444 February 16, 2026 21:19
@wschurman wschurman changed the base branch from graphite-base/444 to main February 16, 2026 21:22
@wschurman wschurman force-pushed the wschurman/02-14-fix_update_integration_test_to_use_blahentity.knexloader_syntax branch from 8b010df to 762ccb8 Compare February 16, 2026 21:23
@wschurman wschurman merged commit 457f58a into main Feb 16, 2026
3 checks passed
@wschurman wschurman deleted the wschurman/02-14-fix_update_integration_test_to_use_blahentity.knexloader_syntax branch February 16, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments