Skip to content

chore: docblock improvements#451

Merged
wschurman merged 1 commit intomainfrom
wschurman/02-16-chore_docblock_improvements
Feb 17, 2026
Merged

chore: docblock improvements#451
wschurman merged 1 commit intomainfrom
wschurman/02-16-chore_docblock_improvements

Conversation

@wschurman
Copy link
Member

@wschurman wschurman commented Feb 16, 2026

Why

Asked claude to audit the docblocks for incorrect or missing info. This is what it mentioned as being good improvements.

How

Update docblocks.

Test Plan

Proofread.

Copy link
Member Author

wschurman commented Feb 16, 2026

@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d9377a2) to head (a30374e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #451    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          109       109            
  Lines        15974     16006    +32     
  Branches      1432       848   -584     
==========================================
+ Hits         15974     16006    +32     
Flag Coverage Δ
integration 23.35% <0.00%> (-0.05%) ⬇️
unittest 95.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wschurman wschurman changed the base branch from wschurman/02-16-fix_make_non-authorized_construction_internal_and_private to graphite-base/451 February 17, 2026 16:38
@wschurman wschurman force-pushed the wschurman/02-16-chore_docblock_improvements branch from 2109394 to 364a3bd Compare February 17, 2026 16:38
@wschurman wschurman requested review from ide and quinlanj February 17, 2026 17:08
@wschurman wschurman marked this pull request as ready for review February 17, 2026 17:08
@wschurman wschurman force-pushed the wschurman/02-16-chore_docblock_improvements branch from 364a3bd to 83d672e Compare February 17, 2026 22:31
@wschurman wschurman changed the base branch from graphite-base/451 to wschurman/02-16-fix_reorganize_constructionutils_to_make_non-public February 17, 2026 22:31
Copy link
Member Author

wschurman commented Feb 17, 2026

Merge activity

  • Feb 17, 10:40 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 17, 10:42 PM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 17, 10:44 PM UTC: @wschurman merged this pull request with Graphite.

@wschurman wschurman changed the base branch from wschurman/02-16-fix_reorganize_constructionutils_to_make_non-public to graphite-base/451 February 17, 2026 22:40
@wschurman wschurman changed the base branch from graphite-base/451 to main February 17, 2026 22:41
@wschurman wschurman force-pushed the wschurman/02-16-chore_docblock_improvements branch from 83d672e to a30374e Compare February 17, 2026 22:41
@wschurman wschurman merged commit c933db1 into main Feb 17, 2026
5 checks passed
@wschurman wschurman deleted the wschurman/02-16-chore_docblock_improvements branch February 17, 2026 22:44
wschurman added a commit that referenced this pull request Feb 17, 2026
# Why

As part of #451, claude noticed that we used both american and british english variants of "adapter"/"adaptor". This makes them consistent by making them all "adapter".

# How

Update name. Technically this is a breaking change but the nature of the library allows `tsc` to catch it in all application code that uses the library.

# Test Plan

`yarn tsc`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants