Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do fail (raise Exception, should be non-0 exit) download if any download fails #1536

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

RF: download - do raise exception if any download fails

09dcf7a
Select commit
Loading
Failed to load commit list.
Draft

Do fail (raise Exception, should be non-0 exit) download if any download fails #1536

RF: download - do raise exception if any download fails
09dcf7a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 23, 2024 in 0s

88.55% (+0.10%) compared to fd3f5e6

View this Pull Request on Codecov

88.55% (+0.10%) compared to fd3f5e6

Details

Codecov Report

Attention: Patch coverage is 54.09836% with 28 lines in your changes missing coverage. Please review.

Project coverage is 88.55%. Comparing base (fd3f5e6) to head (09dcf7a).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
dandi/download.py 39.13% 28 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1536      +/-   ##
==========================================
+ Coverage   88.44%   88.55%   +0.10%     
==========================================
  Files          78       78              
  Lines       10691    10721      +30     
==========================================
+ Hits         9456     9494      +38     
+ Misses       1235     1227       -8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

View more details on Codecov