Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do fail (raise Exception, should be non-0 exit) download if any download fails #1536

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
+132 −86

RF: download - do raise exception if any download fails

09dcf7a
Select commit
Loading
Failed to load commit list.
Draft

Do fail (raise Exception, should be non-0 exit) download if any download fails #1536

RF: download - do raise exception if any download fails
09dcf7a
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Nov 23, 2024 in 6s

3 new alerts

New alerts in code changed by this pull request

  • 1 warning
  • 2 notes

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 778 in dandi/download.py

See this annotation in the file changed.

Code scanning / CodeQL

Unreachable code Warning

This statement is unreachable.

Check notice on line 1046 in dandi/download.py

See this annotation in the file changed.

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.

Check notice on line 1107 in dandi/download.py

See this annotation in the file changed.

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.