Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do fail (raise Exception, should be non-0 exit) download if any download fails #1536

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Do fail (raise Exception, should be non-0 exit) download if any download fails #1536

wants to merge 4 commits into from

Commits on Nov 23, 2024

  1. rf: _download_file - extract logic into a dedicated _check_if_more_at… 

    …tempts_allowed

no functionality changes should be done.

Also removed some stale TODO comments -- DownloadDirectory already downloads
into a file with ".dandidownload" instead of original filename. And we do
report progress. ETA should be estimated outside IMHO.
    @yarikoptic
    yarikoptic committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    9dafa8a View commit details
    Browse the repository at this point in the history

  2. BF: compute final_digest on full file if was resuming download

    @yarikoptic
    yarikoptic committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    c577dce View commit details
    Browse the repository at this point in the history

  3. TST: add test to break download by adding wrong content

    @yarikoptic
    yarikoptic committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    a899a84 View commit details
    Browse the repository at this point in the history

  4. RF: download - do raise exception if any download fails 

    Otherwise it is hard-to-impossible to script using "dandi download" reliably
    @yarikoptic
    yarikoptic committed Nov 23, 2024
    Configuration menu
    Copy the full SHA
    09dcf7a View commit details
    Browse the repository at this point in the history