Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do fail (raise Exception, should be non-0 exit) download if any download fails #1536

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

RF: download - do raise exception if any download fails

09dcf7a
Select commit
Loading
Failed to load commit list.
Draft

Do fail (raise Exception, should be non-0 exit) download if any download fails #1536

RF: download - do raise exception if any download fails
09dcf7a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Nov 23, 2024 in 1s

54.09% of diff hit (target 88.44%)

View this Pull Request on Codecov

54.09% of diff hit (target 88.44%)

Annotations

Check warning on line 757 in dandi/download.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dandi/download.py#L757

Added line #L757 was not covered by tests

Check warning on line 764 in dandi/download.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dandi/download.py#L764

Added line #L764 was not covered by tests

Check warning on line 779 in dandi/download.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dandi/download.py#L778-L779

Added lines #L778 - L779 were not covered by tests

Check warning on line 796 in dandi/download.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dandi/download.py#L796

Added line #L796 was not covered by tests

Check warning on line 1049 in dandi/download.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dandi/download.py#L1048-L1049

Added lines #L1048 - L1049 were not covered by tests

Check warning on line 1053 in dandi/download.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dandi/download.py#L1052-L1053

Added lines #L1052 - L1053 were not covered by tests

Check warning on line 1062 in dandi/download.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dandi/download.py#L1062

Added line #L1062 was not covered by tests

Check warning on line 1065 in dandi/download.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dandi/download.py#L1064-L1065

Added lines #L1064 - L1065 were not covered by tests

Check warning on line 1070 in dandi/download.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dandi/download.py#L1070

Added line #L1070 was not covered by tests

Check warning on line 1077 in dandi/download.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dandi/download.py#L1076-L1077

Added lines #L1076 - L1077 were not covered by tests

Check warning on line 1079 in dandi/download.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dandi/download.py#L1079

Added line #L1079 was not covered by tests

Check warning on line 1082 in dandi/download.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dandi/download.py#L1082

Added line #L1082 was not covered by tests

Check warning on line 1092 in dandi/download.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dandi/download.py#L1090-L1092

Added lines #L1090 - L1092 were not covered by tests

Check warning on line 1105 in dandi/download.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dandi/download.py#L1101-L1105

Added lines #L1101 - L1105 were not covered by tests

Check warning on line 1110 in dandi/download.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dandi/download.py#L1110

Added line #L1110 was not covered by tests

Check warning on line 1117 in dandi/download.py

See this annotation in the file changed.

@codecov codecov / codecov/patch

dandi/download.py#L1116-L1117

Added lines #L1116 - L1117 were not covered by tests