Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_start_planner): add unit tests for freespace pull out path generation #9770

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

WIP

  1. Added TestFreespacePullOut as a friend class to FreespacePullOut class
    • Enabled access to private members from the test class
  2. Added test of path generation

Related links

Parent Issue:

  • Link

How was this PR tested?

confimed colcon test passed with following command

colcon test --event-handlers console_cohesion+ --packages-select autoware_behavior_path_start_planner_module

and passed

1: [----------] 1 test from TestFreespacePullOut
1: [ RUN      ] TestFreespacePullOut.GenerateValidFreespacePullOutPath
1: [INFO 1735056011.155950968] [route_handler]: getMainLanelets: lanelet_sequence = [ids: 508 1304 720 ] (getMainLanelets():2042)
1: primitive: 508
1: preferred_primitive id : 508
1: primitive: 1304
1: preferred_primitive id : 1304
1: primitive: 720
1: preferred_primitive id : 720
1: [       OK ] TestFreespacePullOut.GenerateValidFreespacePullOutPath (582 ms)
1: [----------] 1 test from TestFreespacePullOut (582 ms total)


Notes for reviewers

confirmed that path planning is possible using the freespace planner by turning off shift/geometric pull out, and saved the resulting start/goal poses to yaml for reuse in the test .

Screenshot from 2024-12-24 23-36-12

utilized following command

# disable shift/geometric pull out planner
ros2 param set /planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner start_planner.enable_shift_pull_out false
ros2 param set /planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner start_planner.enable_geometric_pull_out false

# launch autoware
ros2 launch autoware_test_utils psim_road_shoulder.launch.xml vehicle_model:=<vehicle-model> sensor_model:=<sensor-model>

# get yaml file
ros2 service call /autoware_test_utils/topic_snapshot_saver std_srvs/srv/Empty \{\}

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 24, 2024
Copy link

github-actions bot commented Dec 24, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kyoichi-sugahara kyoichi-sugahara force-pushed the test/start_planner/generate_freespace_pull_out_path branch from a5e40bf to 4112c50 Compare December 25, 2024 04:29
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 25, 2024
@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review December 25, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

1 participant