Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_velocity_planner): independent of plugin packages #9760

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Dec 24, 2024

Description

Currently, due to the node test, the behavior_velocity_planner depends on the plugin packages, which is unexpected because we introduced the ROS2's pluginlib so that the node will node depend on the plugin packages.

Referring to the the structure of the behavior_path_planner's node test, this PR changed the structure of the behavior_velocity_planner's node test.
https://github.com/autowarefoundation/autoware.universe/blob/main/planning/behavior_path_planner/autoware_behavior_path_planner/test/test_autoware_behavior_path_planner_node_interface.cpp

The node test in the plugin packages will be added by the succeeding PRs.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 24, 2024
Copy link

github-actions bot commented Dec 24, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@takayuki5168 takayuki5168 force-pushed the feat/independant-behavior-velocity branch from eed6aec to 66b1008 Compare December 24, 2024 07:58
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 25, 2024
@takayuki5168 takayuki5168 force-pushed the feat/independant-behavior-velocity branch from 66b1008 to 90cae7c Compare December 25, 2024 02:27
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 29.72%. Comparing base (421ec7d) to head (90cae7c).

Files with missing lines Patch % Lines
...oware_behavior_velocity_planner/src/test_utils.cpp 50.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9760   +/-   ##
=======================================
  Coverage   29.72%   29.72%           
=======================================
  Files        1451     1461   +10     
  Lines      108839   108938   +99     
  Branches    42741    42775   +34     
=======================================
+ Hits        32348    32381   +33     
- Misses      73313    73377   +64     
- Partials     3178     3180    +2     
Flag Coverage Δ *Carryforward flag
differential 14.53% <50.00%> (?)
total 29.72% <ø> (ø) Carriedforward from 421ec7d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

1 participant