-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(glog_component): prefix package and namespace with autoware #9302
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9302 +/- ##
==========================================
- Coverage 29.51% 29.46% -0.05%
==========================================
Files 1446 1455 +9
Lines 108518 108593 +75
Branches 41396 41400 +4
==========================================
- Hits 32025 31999 -26
- Misses 73372 73476 +104
+ Partials 3121 3118 -3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b159bfb
to
1c89a3e
Compare
Sorry I pasted it from the other place, the table refers to I've renamed the title to Since there are code changes, we cannot use References: |
I agree with |
fc2e701
to
ec44652
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I tested this file, the class could not be found, so I think the following changes are necessary. The same goes for the launch file.
<?xml version="1.0"?>
<launch>
<node_container pkg="rclcpp_components" exec="component_container" name="glog_container" namespace="">
<composable_node pkg="autoware_glog_component" plugin="GlogComponent" name="glog_component"/>
</node_container>
</launch>
@isamu-takagi thanks, I've applied your suggestions. |
Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: Takagi, Isamu <[email protected]>
e171ef0
to
1200ad5
Compare
Also manually checked the usage of |
Description
prefix package and namespace with
autoware
Related links
Parent Issue:
autoware.universe/common
packages autoware#5077How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.