Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(build-and-test): update image tags #9096

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amadeuszsz
Copy link
Contributor

Description

CUDA CI might not work as expected.

In build-and-test CUDA workflow I see packages are not being built properly due to missing libraries e.g. here. This is because previous images had an issue, which is already fixed. This fix applies for already changed image tags. Currently CI operates on deprecated tags and consists of quite old update:

ghcr.io/autowarefoundation/autoware                                                    latest-autoware-universe-cuda   f7ff8a8144d2   5 weeks ago    10.4GB

This PR update tags.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

If applied tags are not correct or I missed any deprecated tag occurrence - feel free to apply your changes.

Interface changes

None.

Effects on system behavior

None.

@amadeuszsz amadeuszsz added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Oct 17, 2024
@amadeuszsz amadeuszsz self-assigned this Oct 17, 2024
Copy link

github-actions bot commented Oct 17, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@amadeuszsz amadeuszsz added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 17, 2024
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Good catch!

@amadeuszsz
Copy link
Contributor Author

amadeuszsz commented Oct 17, 2024

@youtalk

CI fails. If I'm not mistaken, new images are missing CCACHE_DIR environment variable. I'm a bit confused since it exists. Also I'm not sure if this script is applied in CI. If so, maybe hardcoding CCACHE_DIR is a solution.

@youtalk
Copy link
Member

youtalk commented Oct 17, 2024

Hmm... I have not changed ccache configuration for a while.
I need to understand the difference between autoware and autoware.universe build configurations.
Please give me some time to do it.

@youtalk youtalk enabled auto-merge (squash) October 23, 2024 12:30
@youtalk youtalk disabled auto-merge October 23, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants