feat(autoware_autonomous_emergency_braking): Created Schema file and updated ReadME file for parameters setting #10002
+216
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updated ReadME file for parameters setting Signed-off-by: vish0012 <[email protected]>
vish0012
requested review from
mkquda,
danielsanchezaran,
kyoichi-sugahara,
soblin,
TakaHoribe and
tkimura4
as code owners
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
soblin
added
the
run:deploy-docs
|
@vish0012 Please fix the error on the hosting side
|
mitsudome-r
reviewed
Jan 27, 2025
| | aeb_hz | [-] | double | frequency at which AEB operates per second | 10 | | ||
| | speed_calculation_expansion_margin | [m] | double | expansion width of the ego vehicle footprint used when calculating the closest object's speed | 0.7 | | ||
| | path_footprint_extra_margin | [m] | double | this parameters expands the ego footprint used to crop the AEB input pointcloud | 1.0 | | ||
| {{ json_to_markdown("/control/autoware_autonomous_emergency_braking/schema/autonomous_emergency_braking.schema.json") }} |
There was a problem hiding this comment.
You might have to remove the first / in the path to fix the error in documentation rendoring.
Suggested change
| {{ json_to_markdown("/control/autoware_autonomous_emergency_braking/schema/autonomous_emergency_braking.schema.json") }} | |
| {{ json_to_markdown("control/autoware_autonomous_emergency_braking/schema/autonomous_emergency_braking.schema.json") }} |
There was a problem hiding this comment.
Thank you for your guidance, Sensei. I’ve made the modifications as per your suggestion and pushed the changes again. I truly appreciate your advice!
…s per review comments Signed-off-by: vish0012 <[email protected]>
vish0012
force-pushed
the
add-schema-autoware_autonomous_emergency_braking
branch
from
762c625 to
faa0296
Compare
soblin
approved these changes
Jan 29, 2025
Thanks i think it fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the autoware_autonomous_emergency_braking package.
create json shema
update readme file
Related links
Parent Issue:
How was this PR tested?
I try to rectify issue with node , but still have error please have your reference thank you .
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.