-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remaining_distance_time_calculator): skip calculation during parking #9013
base: main
Are you sure you want to change the base?
feat(remaining_distance_time_calculator): skip calculation during parking #9013
Conversation
Signed-off-by: ismetatabay <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9013 +/- ##
==========================================
- Coverage 26.05% 26.04% -0.02%
==========================================
Files 1315 1316 +1
Lines 98503 98439 -64
Branches 40113 40055 -58
==========================================
- Hits 25668 25636 -32
+ Misses 70117 70094 -23
+ Partials 2718 2709 -9
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks so much @ismetatabay for this contribution. |
Signed-off-by: ismetatabay <[email protected]>
a52d9ca
to
314e3a3
Compare
@ahmeddesokyebrahim Thanks!, please check this commit and let me know if you have any concerns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks a lot @ismetatabay !!
This pull request has been automatically marked as stale because it has not had recent activity. |
Description
With this PR, the
autoware_remaining_distance_time_calculator
node stops calculating the remaining time and distance during parking scenarios and sends zero for both remaining time and distance as we discussed in Planning&Control WG Meeting 2024/09/26.Related links
Parent Issue:
How was this PR tested?
Psim
Before this PR
2024-10-02.17-43-22.mp4
After this PR
2024-10-02.17-48-35.mp4
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.