Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update retrospective.md #59

Merged
merged 9 commits into from
Jan 10, 2025
Merged

Update retrospective.md #59

merged 9 commits into from
Jan 10, 2025

Conversation

sashour82
Copy link

Hi Team:
Feel free to update this file whenever needed..

@sashour82
Update retrospective.md
b1c66ab 
Retrospective is written from scratch..
@sashour82 sashour82 self-assigned this Jan 8, 2025
FalaqMajeed
FalaqMajeed previously approved these changes Jan 8, 2025
View reviewed changes
Copy link

@FalaqMajeed FalaqMajeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really good, it perfectly aligns with what we discussed. I’ll go ahead and approve it, so anyone can make modifications until the day before the deadline.

FalaqMajeed
FalaqMajeed reviewed Jan 8, 2025
View reviewed changes
Copy link

@FalaqMajeed FalaqMajeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will pull your changes in my local to resolve these conflicts

FalaqMajeed
FalaqMajeed previously approved these changes Jan 8, 2025
View reviewed changes
Copy link

@FalaqMajeed FalaqMajeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed conflicts

@Moealfadil Moealfadil self-requested a review January 9, 2025 17:30
Moealfadil
Moealfadil approved these changes Jan 10, 2025
View reviewed changes
Copy link

@Moealfadil Moealfadil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

points are clear and goes well with our group, nicely done

@Luyando-Chitindi
Copy link

Thanks Saad and Team! I'll go ahead and approve it!

@Luyando-Chitindi Luyando-Chitindi merged commit c21a5cb into main Jan 10, 2025
10 checks passed
@Moealfadil Moealfadil deleted the crafting_retrospective branch January 10, 2025 15:27
@Luyando-Chitindi Luyando-Chitindi added the documentation Improvements or additions to documentation label Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luyando-Chitindi Luyando-Chitindi Luyando-Chitindi approved these changes

@Moealfadil Moealfadil Moealfadil approved these changes

@FalaqMajeed FalaqMajeed FalaqMajeed left review comments

Assignees

@sashour82 sashour82

Labels
documentation Improvements or additions to documentation
Projects
ET6 Foundations Group 18
Status: DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sashour82 @Luyando-Chitindi @Moealfadil @FalaqMajeed