Skip to content

Commit

Permalink
Revert "Merge branch 'main' into crafting_retrospective"
Browse files Browse the repository at this point in the history
This reverts commit 04aa0b8, reversing
changes made to 550d65a.
  • Loading branch information
Moealfadil committed Jan 9, 2025
1 parent c4970e5 commit 4f6f9f0
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ about: A template PR for code review with a checklist

- [ ] The function's name describes it's behavior
- [ ] The function's name matches the file name
- _It's ok to have extra helper functions if necessary, like with mergesort_
- [ ] The function has correct type annotations
- [ ] The function is not called at the top level of the function file
- _Recursive solutions **can** call the function from **inside** the function body_
Expand All @@ -69,7 +68,7 @@ about: A template PR for code review with a checklist

### Don'ts

- [ ] The function's strategy _is not_ described in any docstrings or tests
- [ ] The function's strategy _is not_ described in the documentation
- [ ] Comments explain the _strategy_, **not** the _implementation_
- [ ] The function _does not_ have more comments than code
- If it does, consider finding a new strategy or a simpler implementation
Expand Down

0 comments on commit 4f6f9f0

Please sign in to comment.