-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include hilla-dev-mode to platform #4946
Comments
Having Maybe it's better to leave If Server side warning:
Browser console warnings:
Those above are extracted from local run, but simlar failures also in CI validation here. |
|
As |
The problem is that when you want to exclude from production build the dependencies only needed for development mode, you usually exclude |
Related-to: vaadin/platform/issues/4946 Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com>
So it's requirement to have |
We could add To fix the problem above, we could exclude with |
chore: change hilla-dev to hilla-dev--mode in hilla Related-to: vaadin/platform/issues/4946 Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com>
Making spring dependencies |
DevToolsDatabase can be deleted. It is integrated into copilot |
Removed DevToolsDatabase and spring-boot-autoconfigure dependency. Feature is integrated into copilot instead. Related-to: vaadin/platform/issues/4946
* chore: remove DevToolsDatabase from hilla-dev-mode Removed DevToolsDatabase and spring-boot-autoconfigure dependency. Feature is integrated into copilot instead. Related-to: vaadin/platform/issues/4946 * chore: remove unused resources from hilla-dev-mode --------- Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Related-to: vaadin/platform/issues/4946 Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com>
chore: change hilla-dev to hilla-dev--mode in hilla Related-to: vaadin/platform/issues/4946 Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com>
* chore: remove DevToolsDatabase from hilla-dev-mode Removed DevToolsDatabase and spring-boot-autoconfigure dependency. Feature is integrated into copilot instead. Related-to: vaadin/platform/issues/4946 * chore: remove unused resources from hilla-dev-mode --------- Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Related-to: vaadin/platform/issues/4946 Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com>
chore: change hilla-dev to hilla-dev--mode in hilla Related-to: vaadin/platform/issues/4946 Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com>
* chore: remove DevToolsDatabase from hilla-dev-mode Removed DevToolsDatabase and spring-boot-autoconfigure dependency. Feature is integrated into copilot instead. Related-to: vaadin/platform/issues/4946 * chore: remove unused resources from hilla-dev-mode --------- Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Related-to: vaadin/platform/issues/4946 Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com>
chore: change hilla-dev to hilla-dev--mode in hilla Related-to: vaadin/platform/issues/4946 Co-authored-by: Manuel Carrasco Moñino <manolo@vaadin.com>
* chore: remove DevToolsDatabase from hilla-dev-mode Removed DevToolsDatabase and spring-boot-autoconfigure dependency. Feature is integrated into copilot instead. Related-to: vaadin/platform/issues/4946 * chore: remove unused resources from hilla-dev-mode --------- Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
Describe your motivation
Include
hilla-dev-mode
as a dependency tovaadin-dev
.Remove
hilla-dev
from Hilla repository as it wouldn't be needed after that.Additional context
Vaadin/Hilla 24.4.
The text was updated successfully, but these errors were encountered: