chore: add hilla-dev-mode in vaadin-dev #4968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZheSun88
approved these changes
Jan 30, 2024
manolo
requested changes
Jan 30, 2024
ZheSun88
added a commit
that referenced
this pull request
Feb 1, 2024
ZheSun88
added a commit
that referenced
this pull request
Feb 1, 2024
* repackage vaadin-maven plugin * reuse flow.version in gradle-plugin * remove the change for the hilla-dev-mode, as it will be covered by #4968 --------- Co-authored-by: Manolo Carrasco <[email protected]>
manolo
force-pushed
the
chore/add-hilla-dev-mode-to-vaadin-dev
branch
2 times, most recently
from
26cff90 to
e30cd53
Compare
But not from the vaadin-core which brings in vaadin-dev with hilla-dev-mode. Excluding vaadin-dev for production builds work better this way.
…ed when hilla + flow is used
manolo
force-pushed
the
chore/add-hilla-dev-mode-to-vaadin-dev
branch
from
1e41c4f to
192bb55
Compare
manolo
reviewed
Feb 6, 2024
| public void load() { | ||
| if (getDriver().getPageSource().contains("<div class=\"message\">Building front-end development bundle</div>")) { | ||
| // Wait for the development bundle to be loaded | ||
| $(NotificationElement.class).waitForFirst(180); |
There was a problem hiding this comment.
I feel that ff the problem is that we need for the bundle to be compiled, probably this fix should be in the testbench instead
ZheSun88
force-pushed
the
chore/add-hilla-dev-mode-to-vaadin-dev
branch
from
8f00e53 to
e142b5d
Compare
Dependencies Report
|
mshabarov
previously requested changes
Feb 6, 2024
manolo
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4946
Note! Need to merge first Hilla's vaadin/hilla#2001.