Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change hilla-dev to hilla-dev-mode in hilla #1992

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

tltv
Copy link
Member

@tltv tltv commented Jan 26, 2024

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac3cee4) 95.31% compared to head (d2a35f7) 95.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1992   +/-   ##
=======================================
  Coverage   95.31%   95.31%           
=======================================
  Files          52       52           
  Lines        3482     3482           
  Branches      524      524           
=======================================
  Hits         3319     3319           
  Misses        129      129           
  Partials       34       34           
Flag Coverage Δ
unittests 95.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tltv tltv marked this pull request as ready for review January 29, 2024 08:53
@manolo manolo enabled auto-merge (squash) January 29, 2024 11:31
@mshabarov
Copy link
Contributor

mshabarov commented Jan 29, 2024

@manolo @tltv how in the end the exclusion of the development dependencies is supposed to work ? Initially, I assumed that hilla-dev would be a part of vaadin-dev and for production mode one should exclude only vaadin-dev even for hybrid apps, as in previous V24 versions.

But with this PR and PRs in platform, I'm a bit confused how it will be achievable in the end. Could you please give your thoughts?

@tltv
Copy link
Member Author

tltv commented Jan 29, 2024

@manolo @tltv how in the end the exclusion of the development dependencies is supposed to work ? Initially, I assumed that hilla-dev would be a part of vaadin-dev and for production mode one should exclude only vaadin-dev even for hybrid apps, as in previous V24 versions.

But with this PR and PRs in platform, I'm a bit confused how it will be achievable in the end. Could you please give your thoughts?

Maybe this discussion can continue in one place here vaadin/platform#4946.

Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@manolo manolo merged commit 01a8b17 into main Jan 29, 2024
15 checks passed
@manolo manolo deleted the chore/hilla-dev-mode-in-hilla-pom branch January 29, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants