-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Flow and Hilla plugins and dependencies #18466
Comments
But hilla-maven-plugin has different code base to flow-maven-plugin which is the same than vaadin-maven-plugin, so we need somehow to have a mechanism to have both aligned |
Please don't bloat the default module; react should be opt-in and not the default for flow apps. |
@knoobie, we understand the concern. It's super important to us, too, that Flow apps stay sleek and efficient. And we'll do our best to ensure that adding React won't weigh things down. Having said that, we also see React as a cool opportunity to give the Vaadin community more options for building awesome web apps. In our view, enabling React support by default for Flow users is an essential component of making Vaadin appealing to a wider audience. It's a bit of a balancing act, and we will do our best to keep things as light and nimble as possible for pure Java developers. |
Two additional things to mention:
|
Yeah, I've noticed the React Router in the other PR. I've come to terms with it, because it removes the vaadin-router - which doesn't look like it gets much love ;) Like in the past with Vaadin Connect; it should be possible to exclude hilla-* from vaadin-core and the whole application should work. (yes, React Router can stay) |
That is indeed the plan. |
Describe your motivation
A hybrid application nowadays requires developers to set the Hilla-originated dependencies in the pom.xml, e.g:
hilla-maven-plugin
(and Gradle plugin as well)hilla-react-spring-boot-starter
andhilla-spring-boot-starter
hilla-bom
andvaadin-bom
hilla-react
andhilla-lit
These are confusing, hard to maintain and a subject of unification.
Describe the solution you'd like
A hybrid application (using Hilla and Flow views/components) should have only Vaadin-originated dependencies
Possible solutions:
hilla-react-spring-boot-starter
as a dependency ofvaadin-spring-boot-starter
hilla-maven-plugin
tovaadin-maven-plugin
since it does to my knowledge cover everything currently covered byvaadin-maven-plugin
in addition to the stuff specific to Hilla.vaadin-maven-plugin
after merging with thehilla-maven-plugin
should still use the pre-compiled bundles for pure Flow apps. The expected output is that it would see that the Hilla deps are in the classpath and always force the hot deploy mode. That have to be changed (maybe by just removing this logic).Additional Context
See the discussion in Slack.
The text was updated successfully, but these errors were encountered: