Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the id and shift of the code with the minimum bit error #21

Open
wants to merge 1 commit into
base: noetic-devel
Choose a base branch
from

Conversation

meyerj
Copy link
Contributor

@meyerj meyerj commented Oct 30, 2023

…from Decoder::decoder().

We did observe some spurious detections of the wrong code, if multiple candidates are sufficiently close, depending on the value of errorCorrection passed to the STag constructor. Even for high values it may be desirable to return the candidate with the least amount of bit errors.

We are using this patch for a while now in our fork (Intermodalics#1), and the number of false detections has been reduced. What do you think?

@MikeK4y
Copy link
Contributor

MikeK4y commented Nov 1, 2023

If we can get the best available result with no significant penalty in performance I think we should merge. Have you noticed any significant delays? I guess that the size of codewords is not big enough to cause a noticeable delay.

@meyerj
Copy link
Contributor Author

meyerj commented Nov 2, 2023

We did not evaluate the impact on run-time explicitly. But indeed, for a library with less than 1000 codewords or so it should not matter much compared to the computational cost of finding STag markers in the image in the first place. Maybe for HD13 or HD11 with more codewords the patch has a more significant impact, but then the importance of not just returning the first, but the best codeword, with the minimal error, is also higher because they tend to be closer to each other, if I understand correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants