Include the offending topic when metadata request returns unknown or unauthorized #1657
+96
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfoltz
force-pushed
the
gfoltz/unknownUnauthorizedTopicLogging
branch
2 times, most recently
from
6cdc768 to
e32865c
Compare
gfoltz
force-pushed
the
gfoltz/unknownUnauthorizedTopicLogging
branch
from
e32865c to
07084ef
Compare
|
Thanks a lot for your work. We're also missing something like this. So we can see what permission is missing for which topic. I really hope this one will make it into a a release asap. |
|
I was doing literally this PR before finding it here, I think it is a really good thing to add ASAP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #957 and #129
A generic
KafkaJSProtocolErroris thrown when a kafka client tries to use a topic that is unknown to the broker or unauthorized for the client. Including the topic name in these cases is very useful for debugging because it allows the engineer to more rapidly know what needs to change with their cluster.This PR includes the following:
KafkaJSUnknownTopicerror which includes atopicpropertyKafkaJSTopicAuthorizationFailederror which includes a `topic propertyerror.topicvalue is included in the log context with the log line.