Fix tests

tulios · Jan 7, 2024 · e32865c · e32865c
1 parent 1ce4ce6
commit e32865c
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 6 deletions.
diff --git a/src/admin/__tests__/fetchTopicMetadata.spec.js b/src/admin/__tests__/fetchTopicMetadata.spec.js
@@ -101,7 +101,10 @@ describe('Admin', () => {
         admin.fetchTopicMetadata({
           topics: [existingTopicName, newTopicName],
         })
-      ).rejects.toHaveProperty('message', 'This server does not host this topic-partition')
+      ).rejects.toHaveProperty(
+        'message',
+        `This server does not host this topic-partition [${newTopicName}]`
+      )
     })
   })
 })
diff --git a/src/errors.js b/src/errors.js
@@ -38,9 +38,14 @@ class KafkaJSOffsetOutOfRange extends KafkaJSProtocolError {
   }
 }
 
+/**
+ * Wraps 'UNKNOWN_TOPIC_OR_PARTITION' (code=3) but is only
+ * used in cases where it is clearly the topic that is unknown
+ * (e.g. a `metadata` request has no partition parameter)
+ */
 class KafkaJSUnknownTopic extends KafkaJSProtocolError {
   constructor(e, { topic }) {
-    super(e)
+    super(e, { retriable: false })
     this.topic = topic
     this.name = 'KafkaJSUnknownTopic'
     this.message = `${this.message} [${this.topic}]`
@@ -55,6 +60,7 @@ class KafkaJSTopicAuthorizationFailed extends KafkaJSProtocolError {
     this.message = `${this.message} [${this.topic})]`
   }
 }
+
 class KafkaJSMemberIdRequired extends KafkaJSProtocolError {
   constructor(e, { memberId }) {
     super(e)

diff --git a/src/protocol/error.js b/src/protocol/error.js
@@ -24,7 +24,7 @@ const errorCodes = [
   {
     type: 'UNKNOWN_TOPIC_OR_PARTITION',
     code: 3,
-    retriable: false,
+    retriable: true,
     message: 'This server does not host this topic-partition',
   },
   {

diff --git a/src/protocol/requests/metadata/v0/response.spec.js b/src/protocol/requests/metadata/v0/response.spec.js
@@ -71,7 +71,7 @@ describe('Protocol > Requests > Metadata > v0', () => {
     test('when topicErrorCode is UNKNOWN_TOPIC_OR_PARTITION', async () => {
       decoded.topicMetadata[0].topicErrorCode = 3
       await expect(response.parse(decoded)).rejects.toMatchObject({
-        message: createErrorFromCode(3).message,
+        message: createErrorFromCode(3).message + ' [test-topic-1]',
         retriable: false,
         type: 'UNKNOWN_TOPIC_OR_PARTITION',
         code: 3,
@@ -83,7 +83,7 @@ describe('Protocol > Requests > Metadata > v0', () => {
     test('when topicErrorCode is TOPIC_AUTHORIZATION_FAILED', async () => {
       decoded.topicMetadata[0].topicErrorCode = 29
       await expect(response.parse(decoded)).rejects.toMatchObject({
-        message: createErrorFromCode(29).message,
+        message: createErrorFromCode(29).message + ' [test-topic-1]',
         retriable: false,
         type: 'TOPIC_AUTHORIZATION_FAILED',
         code: 29,

diff --git a/types/index.d.ts b/types/index.d.ts
@@ -1290,6 +1290,7 @@ export interface KafkaJSOffsetOutOfRangeMetadata {
 export interface KafkaJSUnknownTopicMetadata {
   topic: string
 }
+
 export interface KafkaJSTopicAuthorizationFailedMetadata {
   topic: string
 }

diff --git a/types/tests.ts b/types/tests.ts
@@ -342,4 +342,4 @@ new KafkaJSServerDoesNotSupportApiKey(
 )
 
 new KafkaJSUnknownTopic('This server does not host this topic-partition', { topic: 'my_topic' })
-new KafkaJSTopicAuthorizationFailed('Not authorized to access topics: [Topic authorization failed]', { topic: 'my_topic' })
+new KafkaJSTopicAuthorizationFailed('Not authorized to access topics: [Topic authorization failed]', { topic: 'my_topic' })