Fix tests

src/admin/__tests__/alterPartitionReassignments.spec.js

@@ -105,7 +105,7 @@ describe('Admin', () => {
       )
     })
 
-    test('throws an error if the if trying to reassign partitions for a topic that does not exist', async () => {
+    test('throws an error when trying to reassign partitions for a topic that does not exist', async () => {
       admin = createAdmin({ cluster: createCluster(), logger: newLogger() })
 
       await admin.connect()
@@ -121,7 +121,7 @@ describe('Admin', () => {
           message: 'Errors altering partition reassignments',
           errors: expect.arrayContaining([
             expect.objectContaining({
-              message: 'This server does not host this topic-partition',
+              message: `This server does not host this topic-partition [${topicName + 'x'}]`,
               topic: topicName + 'x',
               partition: 0,
             }),

src/admin/__tests__/createPartitions.spec.js

@@ -58,7 +58,10 @@ describe('Admin', () => {
         admin.createPartitions({
           topicPartitions: [{ topic: topicName + 'x', count: 3 }],
         })
-      ).rejects.toHaveProperty('message', 'This server does not host this topic-partition')
+      ).rejects.toHaveProperty(
+        'message',
+        `This server does not host this topic-partition [${topicName + 'x'}]`
+      )
     })
 
     test('throws an error trying to assign invalid broker', async () => {

src/admin/__tests__/fetchTopicMetadata.spec.js

@@ -101,7 +101,10 @@ describe('Admin', () => {
         admin.fetchTopicMetadata({
           topics: [existingTopicName, newTopicName],
         })
-      ).rejects.toHaveProperty('message', 'This server does not host this topic-partition')
+      ).rejects.toHaveProperty(
+        'message',
+        `This server does not host this topic-partition [${newTopicName}]`
+      )
     })
   })
 })

src/errors.js

@@ -38,9 +38,14 @@ class KafkaJSOffsetOutOfRange extends KafkaJSProtocolError {
   }
 }
 
+/**
+ * Wraps 'UNKNOWN_TOPIC_OR_PARTITION' (code=3) but is only
+ * used in cases where it is clearly the topic that is unknown
+ * (e.g. a `metadata` request has no partition parameter)
+ */
 class KafkaJSUnknownTopic extends KafkaJSProtocolError {
   constructor(e, { topic }) {
-    super(e)
+    super(e, { retriable: false })
     this.topic = topic
     this.name = 'KafkaJSUnknownTopic'
     this.message = `${this.message} [${this.topic}]`
@@ -55,6 +60,7 @@ class KafkaJSTopicAuthorizationFailed extends KafkaJSProtocolError {
     this.message = `${this.message} [${this.topic})]`
   }
 }
+
 class KafkaJSMemberIdRequired extends KafkaJSProtocolError {
   constructor(e, { memberId }) {
     super(e)

src/protocol/error.js

@@ -24,7 +24,7 @@ const errorCodes = [
   {
     type: 'UNKNOWN_TOPIC_OR_PARTITION',
     code: 3,
-    retriable: false,
+    retriable: true,
     message: 'This server does not host this topic-partition',
   },
   {

types/index.d.ts

@@ -1290,6 +1290,7 @@ export interface KafkaJSOffsetOutOfRangeMetadata {
 export interface KafkaJSUnknownTopicMetadata {
   topic: string
 }
+
 export interface KafkaJSTopicAuthorizationFailedMetadata {
   topic: string
 }

types/tests.ts

@@ -342,4 +342,4 @@ new KafkaJSServerDoesNotSupportApiKey(
 )
 
 new KafkaJSUnknownTopic('This server does not host this topic-partition', { topic: 'my_topic' })
-new KafkaJSTopicAuthorizationFailed('Not authorized to access topics: [Topic authorization failed]', { topic: 'my_topic' })
+new KafkaJSTopicAuthorizationFailed('Not authorized to access topics: [Topic authorization failed]', { topic: 'my_topic' })